Hotfix az rewrite and storage_preview #1075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
3 tasks
Juliehzl
reviewed
Nov 7, 2019
mmyyrroonn
reviewed
Nov 7, 2019
|
|
||
| # TODO migrate to public azdev | ||
| echo "Running linter..." | ||
| # azdev cli-lint --ci --extensions $ext |
Contributor
There was a problem hiding this comment.
should we run the azdev linter and azdev verify load-all?
Contributor
Author
There was a problem hiding this comment.
Currently, the public azdev doesn't have those two commands. So it's a dangerous hotfix which will open the Pandora Box that leave extension commands without some correctness verification.
Juliehzl
approved these changes
Nov 7, 2019
jiasli
approved these changes
Nov 7, 2019
mmyyrroonn
approved these changes
Nov 7, 2019
This was referenced Nov 7, 2019
Closed
haroldrandom
pushed a commit
to haroldrandom/azure-cli-extensions
that referenced
this pull request
Nov 8, 2019
zikalino
pushed a commit
that referenced
this pull request
Nov 18, 2019
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
…re#1075 (Azure#1082) * [azdev] Upgrade linter to the public azdev mentioned at hotfix PR Azure#1075 * Optimize readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: This hotfix comments out
azdev verify load-allandazdev cli-linter(from azure-cli) , which opens the Pandora box that leave extension commands without some correctness verification. Will migrate those function into the public azure-cli-dev-tools ASAP.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: